575941 - "Open with" selection: wrong application name displayed

Status: NEW

(Firefox :: File Handling, defect)

Description

[Erik Hahn]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:2.0b2pre) Gecko/20100629 Minefield/4.0b2pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:2.0b2pre) Gecko/20100629 Minefield/4.0b2pre

When clicking a pdf link, Firefox offers to open the file with "SumatraPDF (default)2. However, the actual default application for PDF files is Evince, though SumatraPDF used to be. Also, the file is correctly opened in Evince.

Reproducible: Didn't try

Steps to Reproduce:
1.Install Evince
2.Set Evince as the default PDF viewer (via the "Open with" entry in the context menu in Explorer as Evince does not offer this in its preferences dialog)
3.Click any link to a pdf file with no PDF plugin enabled
Actual Results:  
The name of your previous PDF viewer is displayed in the "Open with" field.

Expected Results:  
"Evince" is displayed as your default PDF viewer.

Comment 1

[Jim Mathies [:jimm]]

Possibly Evince isn't registered right? We dig through the registry for these app lists.

Comment 2

[Erik Hahn]

(In reply to comment #1)
> Possibly Evince isn't registered right? We dig through the registry for these
> app lists.

Are there any registry entries I should check? In the folder options 
dialog, "evince" is the listed application for "PDF file". The icon, 
though, is the one of SumatraPDF (probably because evince provides none.)

Comment 3

[Jim Mathies [:jimm]]

(In reply to comment #2)
> (In reply to comment #1)
> > Possibly Evince isn't registered right? We dig through the registry for these
> > app lists.
> 
> Are there any registry entries I should check? In the folder options 
> dialog, "evince" is the listed application for "PDF file". The icon, 
> though, is the one of SumatraPDF (probably because evince provides none.)

This is the routine that generates the list, so some where in here we are getting a wrong value:

http://mxr.mozilla.org/mozilla-central/source/uriloader/exthandler/win/nsMIMEInfoWin.cpp#619

Comment 4

[Erik Hahn]

HKEY_CLASSES_ROOT\.pdf only contains two strings: (Default) with "SumatraPDF" and "Content Type" with "application/pdf".  
HKEY_CURRENT_USER\Software\Microsoft\Windows\CurrentVersion\Explorer\FileExts\.pdf actually points at "evince.exe".

Comment 5

[Erik Hahn]

Attachment: Export of HKEY_CURRENT_USER\Software\Microsoft\Windows\CurrentVersion\Explorer\FileExts\.pdf

Comment 6

[Boris Zbarsky [:bzbarsky]]

Yeah, definitely sounds like evince isn't set up correctly as the viewer (note the incorrect icon in comment 2; even Windows is confused about which program is supposed to be handling things!).

Comment 7

[Erik Hahn]

(In reply to comment #6)
> Yeah, definitely sounds like evince isn't set up correctly as the viewer (note
> the incorrect icon in comment 2; even Windows is confused about which program
> is supposed to be handling things!).

In case I've been misunderstood, the application icon displayed in the folder options is indeed the one of evince. The icon that is used by explorer for pdf files, however, is the one provided by SumatraPDF. I've examined evince.exe using the resource hacker utility, it contains only that application icon, no icon for pdf documents.

Comment 8

[boppreh]

I also got bit by this bug, but the context made it a security problem. I'm on Firefox 55.0.3 (64-bit), Windows 10.

My default application for opening .py files is python.exe, which executes the script. However, when Firefox prompts to open or save a .py file, the dialog has "Open with: Sublime Text (default)". The bug is that selecting this option doesn't open Sublime Text as implied, but the actual default "python.exe".

Which means that instead of displaying the contents of the script, it *runs* the script. I'm attaching screenshot and contents of registry `HKEY_CURRENT_USER\Software\Microsoft\Windows\CurrentVersion\Explorer\FileExts\.py\OpenWithList`.

Comment 9

[boppreh]

Attachment: Screenshot of incorrectly named default "open with" program

Comment 10

[boppreh]

Attachment: windows py registry.reg

Comment 11

[Boris Zbarsky [:bzbarsky]]

Jim, can you take a look at that?  For something like python, that seems really bad....

Comment 12

[Jim Mathies [:jimm]]

(In reply to boppreh from comment #8)
> I also got bit by this bug, but the context made it a security problem. I'm
> on Firefox 55.0.3 (64-bit), Windows 10.
> 
> My default application for opening .py files is python.exe, which executes
> the script. However, when Firefox prompts to open or save a .py file, the
> dialog has "Open with: Sublime Text (default)". The bug is that selecting
> this option doesn't open Sublime Text as implied, but the actual default
> "python.exe".
> 
> Which means that instead of displaying the contents of the script, it *runs*
> the script. I'm attaching screenshot and contents of registry
> `HKEY_CURRENT_USER\Software\Microsoft\Windows\CurrentVersion\Explorer\FileExt
> s\.py\OpenWithList`.

We query the operating system directly for the proper handler here [1]. If that returns the python exe well then we display it. It's possible there's a bug in here but I'm going to need to be able to reproduce the issue. Anyone know if there are good steps to reproduce this?

[1] https://dxr.mozilla.org/mozilla-central/source/uriloader/exthandler/win/nsOSHelperAppService.cpp#423

Comment 13

[Boris Zbarsky [:bzbarsky]]

The problem is that we claim that we wil use "Sublime Text", but that's not the app we actually run...

What registry values might be relevant here that boppreh could check?

Comment 14

[boppreh]

I'm not sure how relevant they are, but I've added some of my "open with" registry values: https://bugzilla.mozilla.org/attachment.cgi?id=8910513

And this bug is still present in Firefox Nightly 58.0a1 (2017-10-16) (64-bit).

Comment 15

[Jim Mathies [:jimm]]

(In reply to boppreh from comment #14)
> I'm not sure how relevant they are, but I've added some of my "open with"
> registry values: https://bugzilla.mozilla.org/attachment.cgi?id=8910513
> 
> And this bug is still present in Firefox Nightly 58.0a1 (2017-10-16)
> (64-bit).

Those are set by the system based on your actions, we don't use these values in choosing apps other than to add them to a list of possible apps you might choose from via the app picker.

Comment 16

[David Wheeler]

Attachment: same problem

Thanks from onincomse1983.